Skip to content
This repository has been archived by the owner on Dec 12, 2018. It is now read-only.

Encapsulate dependencies #3

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Encapsulate dependencies #3

merged 1 commit into from
Jul 3, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jul 2, 2018

Related PRs:

Fix #4
Fix #1

This PR includes the following changes:

  • Encapsulates dependencies so they aren't included in header files forcing dependencies on others (The main thing being rapidjson)
  • Fixes build configs (include_dirs should never need to be specified like it was, changed to just use deps)
  • Forward declared some things to make headers include less headers. (which causes longer rebuild time)
  • Fixed some formatting problems to be more consistent with brave + chromium coding guidelines:
    • No tabs, use 2 spaces instead (especially no mixing tabs and spacing)
    • Removes trailing whitespace on lines
    • Removes extra lines, especially those with only whitespace
    • Fixed spacing
    • Headers alphabetical
    • namespace end comment should be 2 spaces, then // then space then namespace
    • cc's header should be first.
    • accessor modifiers (public, private, protected, 1 space)
    • line continuations 4 spaces, or align parameters
  • Fixed a complex type needs copy constructor error on a couple classes
  • Fixed Code we write should have MPL 2.0 headers #1 header file using the correct license.

@bbondy bbondy force-pushed the encapsulate-deps branch from 47d446c to f118e44 Compare July 3, 2018 02:09
@bbondy bbondy changed the title WIP: Encapsulate dependencies Encapsulate dependencies Jul 3, 2018
@bbondy bbondy self-assigned this Jul 3, 2018
@bbondy bbondy force-pushed the encapsulate-deps branch from f118e44 to 059445a Compare July 3, 2018 17:08
@bbondy bbondy force-pushed the encapsulate-deps branch from 059445a to 56e8b0f Compare July 3, 2018 19:40
@gdregalo gdregalo merged commit c2fffa8 into master Jul 3, 2018
@gdregalo gdregalo deleted the encapsulate-deps branch July 3, 2018 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants